-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipam: deepcopy interface resource correctly. #26998
Merged
tommyp1ckles
merged 1 commit into
cilium:main
from
tommyp1ckles:pr/tp/fix-false-deepcopy-causing-races
Mar 15, 2024
Merged
ipam: deepcopy interface resource correctly. #26998
tommyp1ckles
merged 1 commit into
cilium:main
from
tommyp1ckles:pr/tp/fix-false-deepcopy-causing-races
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b52cfe
to
0ebd5f1
Compare
0ebd5f1
to
39e1697
Compare
christarazi
approved these changes
Aug 1, 2023
gandro
approved these changes
Aug 2, 2023
39e1697
to
5976a48
Compare
/test |
5976a48
to
4b4e8d0
Compare
/test |
failures are flake this is partially trying to address |
/test |
1 similar comment
/test |
4b4e8d0
to
5383cea
Compare
5383cea
to
c4b8d3e
Compare
/test |
Think this is still desired, if tests pass following the last fix for the referenced test. |
c4b8d3e
to
d2c24d0
Compare
@hemanthmalla Could you take a look on behalf of cilium/azure? |
hemanthmalla
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ipam
Impacts IP address management functionality.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipam: deepcopy interface resource correctly.
Currently only used by azure ipam test mocks, was resulting in race
condition prone code where underlying interface addresses where being
shared across resources.
This ensures that the revision interface is correctly deepcopied such
that the underlying resource is also safely copied.
This seems at least partially related to flake #26617.
Addresses: #26617
Signed-off-by: Tom Hadlaw tom.hadlaw@isovalent.com